"First Person Shooter" genre search category is broken. Topic is solved

Trouble playing a game? Game not running well? Ask help here.

Moderator: LW Moderator

Post Reply
BZPlasma
Newbie
Posts: 6
Joined: Wed Mar 21, 2018 6:47 pm
Has thanked: 3 times
Been thanked: 1 time

"First Person Shooter" genre search category is broken.  Topic is solved

Post by BZPlasma »

Hello,

Apologies if this is not in the correct forum topic, but I wanted to let you know that the genre search for First Person Shooter isn't working. It just displays "Games in the genre First Person Shooter: No games found for that genre" despite it showing "First Person Shooters: 2698" on the same page. It's the only category in the genre search that doesn't work. Every other genre search works fine.

I don't know how to attach pictures, so I've included an Imgur link showing proof of the broken FPS genre search.
https://imgur.com/a/XEx613s

Is there any chance you could fix the search?

Thanks
User avatar
annoyment
Super Member
Posts: 2130
Joined: Tue Jul 14, 2015 9:30 pm
Location: Land of KEBAB REMOVERS
Has thanked: 163 times
Been thanked: 231 times

Re: "First Person Shooter" genre search category is broken.

Post by annoyment »

HIDE: ON
You need to reply or thank to this topic before you can view the hidden message
So is "Adventure" on AL it seems, maybe the error is in javascript mistaking the number 0 for a NULL as a value to be parsed for the getgenre function (the only other issue I can think of, is that the amount of titles to display is big enough for a silly overflow, but that is just plain stupid :omg: ) :|
Just hoping there won't be a need to fix the genre value for each individual entry in the sites though (or that the fix isn't difficult or colossal in scope in general) :(
Windows is shutting down[/hide]
"Hellos, plz help with this, will help backward." -Wimpy
Image
User avatar
Molitor
3DSL Moderator
Posts: 1253
Joined: Mon Feb 27, 2012 6:53 pm
Location: France
Has thanked: 48 times
Been thanked: 211 times

Re: "First Person Shooter" genre search category is broken.

Post by Molitor »

It does work on my side: "No games found for that genre" is shown for a second or so, and then the actual list appears.
User avatar
annoyment
Super Member
Posts: 2130
Joined: Tue Jul 14, 2015 9:30 pm
Location: Land of KEBAB REMOVERS
Has thanked: 163 times
Been thanked: 231 times

Re: "First Person Shooter" genre search category is broken.

Post by annoyment »

Then it may be browser-dependent (regarding javascript implementation update, or just any standard-related update in general :huh: ) - the issue still persists on my side, via Desktop Firefox latest, Desktop IE 11, Desktop Edge latest, & Android Chrome 65.Aprilmaybe :lol: sorry for the news :(
"Hellos, plz help with this, will help backward." -Wimpy
Image
BZPlasma
Newbie
Posts: 6
Joined: Wed Mar 21, 2018 6:47 pm
Has thanked: 3 times
Been thanked: 1 time

Re: "First Person Shooter" genre search category is broken.

Post by BZPlasma »

The problem is that EVERY SINGLE other genre search shows results perfectly. I tested every single genre category. It is literally ONLY the "First Person Shooter" category that displays no games found for that genre. I tested it with IE, Firefox and Google Chrome. Still the same.

Here's a picture with proof. I tested 8 categories and ONLY First Person Shooter has no games found
https://imgur.com/a/Rt4NcHt

I know it's definitely not browser specific because all the browsers work the same and only the FPS category is broken.

PS: I don't know if it matters, but when I hover over the FPS genre, I get "javascript:getgenre('0'). All the others have numbers 1 and up.

Edit: I tested Adventure Legends and only the "Adventure" genre search category "javascript:getgenre('0') has no games found. I now believe that the 0 = NULL is indeed the problem. Every other genre search with 1 and up work perfectly.
User avatar
hfric
3DSL Moderator
Posts: 5026
Joined: Sun Jan 09, 2005 2:51 am
Has thanked: 49 times
Been thanked: 233 times

Re: "First Person Shooter" genre search category is broken.

Post by hfric »

and there is also this slight bug that sometimes will irritate you ... when you click the genre (in the A-Z index) it will show the titles but, click like 5 pixels down and ... you get no games found
▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬ஜ۩۞۩ஜ▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬
Image
▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬ஜ۩۞۩ஜ▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬
User avatar
Scaryfun
3DSL Admin
Posts: 11290
Joined: Wed Jun 02, 2004 9:27 pm
Location: Toronto, Canada.
Has thanked: 1665 times
Been thanked: 886 times
Contact:

Re: "First Person Shooter" genre search category is broken.

Post by Scaryfun »

Yes the html code looks for code '0' and for unkown reason can't find it for first-person shooters or adventure games lists. Maybe the only cure would be using a different number code.
Here is the code, games[4] through games[9] at end is it checking the six different genre fields in database -

function getgenre(genre)
{
var writing=navigation();
var gamesfound=false;
var noGenre=false;
for (i=0;i<games.length;i++)
{
if (gamesfound==false && ShowInterface==true)
{
switch (genre)
{
case '0':
writing+='<p><font size=\"6\">Games in the genre '+'First Person Shooter'+':</font></p>';
break;
case '1':
writing+='<p><font size=\"6\">Games in the genre '+'Third Person Shooter'+':</font></p>';
break;
}
}
gamesfound=true;
if (games[4]==genre)
{
writing+=listgame(i,"true","false");
noGenre=true;
} else if (games[5]==genre)
{
writing+=listgame(i,"true","false");
noGenre=true;
} else if (games[6]==genre)
{
writing+=listgame(i,"true","false");
noGenre=true;
} else if (games[7]==genre)
{
writing+=listgame(i,"true","false");
noGenre=true;
} else if (games[8]==genre)
{
writing+=listgame(i,"true","false");
noGenre=true;
} else if (games[9]==genre)
{
writing+=listgame(i,"true","false");
noGenre=true;
}
}
if (noGenre==false)
{
writing+='<p><font size=\"6\">No games found for that genre</font></p>';
}
Image
BZPlasma
Newbie
Posts: 6
Joined: Wed Mar 21, 2018 6:47 pm
Has thanked: 3 times
Been thanked: 1 time

Re: "First Person Shooter" genre search category is broken.

Post by BZPlasma »

Is it possible for someone at Legendsworld.net to fix the search for First Person Shooter and Adventure genre by changing the 0 to another number that's not being used? It would be great if those 2 broken genre searches actually worked. That's pretty much the reason I created this topic in the first place.
User avatar
Scaryfun
3DSL Admin
Posts: 11290
Joined: Wed Jun 02, 2004 9:27 pm
Location: Toronto, Canada.
Has thanked: 1665 times
Been thanked: 886 times
Contact:

Re: "First Person Shooter" genre search category is broken.

Post by Scaryfun »

Success! :D
Our webmaster found in database code that blanked out the '0' genre when adding data for those FPS or Adventure games to database. Now those zero genres are put in database just like all other genres so the index lists now work correctly. Yay...much thanks to him.
Image
BZPlasma
Newbie
Posts: 6
Joined: Wed Mar 21, 2018 6:47 pm
Has thanked: 3 times
Been thanked: 1 time

Re: "First Person Shooter" genre search category is broken.

Post by BZPlasma »

Scaryfun wrote:Success! :D
Our webmaster found in database code that blanked out the '0' genre when adding data for those FPS or Adventure games to database. Now those zero genres are put in database just like all other genres so the index lists now work correctly. Yay...much thanks to him.
Awesome! Great work. I can confirm that the "Adventure" and "First Person Shooter" genre searches work perfectly. Be sure to thank your webmaster for me. :up: :thanks:
Post Reply